Skip to content

Update CommandLineTest.testCommandLineVersion() #9695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2020

Conversation

tlk
Copy link
Contributor

@tlk tlk commented Jan 31, 2020

This makes the CommandLineTest.testCommandLineVersion work with the latest code.

Looks like the test was broken by the System.out.println statement in Base.java 824567d

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open [Pull Requests]

Looks like the test was broken by the System.out.println statement in Base.java
arduino@824567d
@cmaglie
Copy link
Member

cmaglie commented Feb 6, 2020

We should probably do the println only when not running in command line mode: it doesn't make sense to have that printed when launched with --version I expect only the version in the output.

May you change the PR accordingly?

@cmaglie cmaglie self-assigned this Feb 6, 2020
@tlk
Copy link
Contributor Author

tlk commented Feb 6, 2020

Good point, will have a look at that. Thanks!

@tlk tlk force-pushed the tlk/fix-commandline-test branch from e50b44b to 8c3f214 Compare February 7, 2020 01:54
@cmaglie cmaglie merged commit f62b5db into arduino:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants