Fix bogus port disconnection during serial event #9862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9785 and probably many others
This commit strongly simplifies the serial list code
Pluggable discovery introduced a bug since
BoardPort.toString()
started reporting only the name of the port, not the completename_vid_pid
needed to matchliblistserial
output.Adding
.toCompleteString()
almost solves the bogus disconnection part alone, butresolveDeviceByVendorIdProductId()
uses "0x" prefixes VID/PID, breaking it again.In addition, all the logic used to match a board with its bootloader (to obtain a serial number on 32u4 boards) has been completely removed since it is currently useless (and unused).
All Submissions:
New Feature Submissions:
Changes to Core Features: