Fixed PWM frequency glitch #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmaglie good since previously holes were present in the waveform. We should also change the PWM frequency to be consistent with other boards. |
|
At the moment is 48MHz / 256 = 187.5KHz, we can prescale by another 256 and get a (weird but) more manageable: 187.500 / 256 = 732.4Hz |
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
boseji
pushed a commit
to go-ut/combined-ArduinoCore-samd
that referenced
this pull request
May 30, 2020
minor correction to comments in variants/metro_m4/variant.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the TC timer used for PWM was disabled and reenabled on each call to
analogWrite, this lead to inconsistent PWM periods.This PR fixes this behaviour.