[Wire] simplified coding unnecessarily complex (hfvogt) #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the wire library there are several functions where
an unnecessarily complex coding has been used:
- endTransmission: the availability of data is already
checked in while(...), therefore need not be checked
again in the loop.
- requestFrom: the for-loop has a predefined and fixed
number of loops. Therefore a check whether the last
element has been reached is unnecessary and does not
add any benefit.
Fixes arduino#20
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
|
Seems good to me 👍 |
|
idem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the optimizations suggested in #20.
/cc @hfvogt @facchinm