A fix for the SerialUSB buffer overflow bug. #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send the data in chunks based on the buffer size instead of assuming that the whole send data will fit into the buffer.
|
I believe this issue has now been resolved in commit: |
|
Hi @GabrielNotman, first of all, sorry for the lack of feedback, This is a very busy period and we failed to leave a comment...
Yes, we were working on a bunch of USB fix, and your patch was basically already included in them, BTW it was a good fix for a compelling problem, so thank you anyway for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the data in chunks based on the buffer size
instead of assuming that the whole send data
will fit into the buffer.
This is one possible fix for the issue raised here:
https://forum.arduino.cc/index.php?topic=340897.0