Skip to content

[USB CDC] Only re-enable IRQ if PRIMASK was 0 before disabling IRQ #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

sandeepmistry
Copy link
Contributor

As discussed by @matthijskooijman in #65 (comment):

Also, it might be good to let accept() use the same conditional interrupts() call (in a separate commit, of course)?

Also, incorporated feedback from #65 (comment)

To emphasize the non-portability (and reduce confusion for people reading the code), it might be better to even just use __disable_irq() and __enable_irq() directly?

@matthijskooijman
Copy link
Collaborator

Looks good! I would remove the { } from the if for conciseness, but that's a matter of style/taste :-)

@cmaglie
Copy link
Member

cmaglie commented Feb 18, 2016

Rebased and merged.

@cmaglie cmaglie closed this Feb 18, 2016
@cmaglie cmaglie added this to the Release 1.6.4 milestone Feb 18, 2016
@sandeepmistry sandeepmistry deleted the usb-cdc-accept-primask branch April 19, 2016 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants