SdFat failing using SPI or SPI1 (after updating overlay).

[mjs513]

@KurtE and myself tried running a couple of sdfat test cases that work when using Giga Mbed.

Output of Serial Monitor
What happens they compile no issue and load no issued using zephyr. Howver, immediately after upload it hangs. Did try looking as serial1 output but no output.

Using spi:
Example Sketch
SDFat_Giga_zephyr-241209a.zip

Target board + cli verbose compilation output
Full verbose compilation output, ideally with arduino-cli invocation or from IDE 2.3.3+
SDFat_compile.txt

Using SPI1 we used a method to specify our own SPI driver just in case but the same thing occurs:
Example Skectch
sketch_dec6a.ino.zip

Overlay was updated to specify:

&spi5 {
	status = "okay";
	pinctrl-0 = <&spi5_nss_pk1 &spi5_sck_ph6
		     &spi5_miso_pj11 &spi5_mosi_pj10>;
	pinctrl-names = "default";
};

Not sure what else you need.

EDIT: I am using as SDCARD adapter from Adafruit: https://learn.adafruit.com/adafruit-microsd-spi-sdio/overview

[facchinm]

Debugging journal

How to debug this issue:

• with UART connected -> we see the shell, type sketch, get
  [00:00:01.528,000] <err> llext: Failed to copy regions, ret -12 Failed to load sketch, rc -12

  • Reason: the sketch is too big to fit in LLEXT HEAP (the one that will be used when interacted via shell)
  • Solution: temporarily reduce CONFIG_HEAP_MEM_POOL_SIZE to 2048, increase CONFIG_LLEXT_HEAP_SIZE to 64

• next error:
  [00:00:03.332,000] <err> llext: Undefined symbol with no entry in symbol table isalpha, offset 13200, link 0 [00:00:03.343,000] <err> llext: Failed to link, ret -61 Failed to load sketch, rc -61

  • Reason: symbol not yet exported in llext_exports.c
  • Solution: add isaplha and isupper to that file

• next error:
  CDC serial starts, asks for Chip select, fails
  UART output: [00:00:24.651,000] <err> spi_ll_stm32: Unsupported frequency 400000Hz, max 120000000Hz, min 937500Hz
  Quick and dirt fix:

   diff --git a/libraries/SPI/SPI.cpp b/libraries/SPI/SPI.cpp
index cfea9af..f55c17c 100644
--- a/libraries/SPI/SPI.cpp
+++ b/libraries/SPI/SPI.cpp
@@ -79,9 +79,13 @@ void arduino::ZephyrSPI::usingInterrupt(int interruptNumber) {
 void arduino::ZephyrSPI::notUsingInterrupt(int interruptNumber) {
 }
 
+#ifndef SPI_MIN_CLOCK_FEQUENCY
+#define SPI_MIN_CLOCK_FEQUENCY 1000000
+#endif
+
 void arduino::ZephyrSPI::beginTransaction(SPISettings settings) {
   memset(&config, 0, sizeof(config));
-  config.frequency = settings.getClockFreq();
+  config.frequency = settings.getClockFreq() > SPI_MIN_CLOCK_FEQUENCY ? settings.getClockFreq() : SPI_MIN_CLOCK_FEQUENCY;
   auto mode = SPI_MODE_CPOL | SPI_MODE_CPHA;
   switch (settings.getDataMode()) {
     case SPI_MODE0:

Finally

Card successfully initialized.

Card size: 31915 MB (MB = 1,000,000 bytes)


Volume is FAT32, Cluster size (bytes): 8192

Files found (date time size name):
2024-12-09 15:01          0 ciao!!

Patches incoming

[KurtE]

Thanks,

Learning some new stuff.

My SPI test to ILI9341 display is also failing as mentioned on the thread and hit the same first error
First up figure out what terminal app I want to use on Ubuntu... currently just using second Arduino monitor...

[facchinm]

#6 should contain all the needed fixes and a prebuilt loader based on the "old" device tree (so with 2 spi, SPI object on ICSP header). Maybe these fixes also allow ILI9341 to run (the min_frequency could be the culprit).

Hope the debugging journal will help a bit future contributors, it might be nice to transform it in something more structured

[mjs513]

Going to agree with @KurtE - learning a lot now with using zephyr

[KurtE]

Sorry, I am new to this system. So when you say:

with UART connected -> we see the shell, type sketch, get
[00:00:01.528,000] <err> llext: Failed to copy regions, ret -12                                              Failed to load sketch, rc -12

Reason: the sketch is too big to fit in LLEXT HEAP (the one that will be used when interacted via shell)
Solution: temporarily reduce CONFIG_HEAP_MEM_POOL_SIZE to 2048, increase CONFIG_LLEXT_HEAP_SIZE to 64

How do you do this?
Can you do this within the UART?
Or do you need to edit some file and change it? Which one? autoconf.h? in the directory like:
/home/kurte/github/ArduinoCore-zephyr/variants/arduino_giga_r1_m7/llext-edk/include/zephyr/include/generated

Note: I see those defines in several files

~/github/ArduinoCore-zephyr/loader/prj.conf:
   21  CONFIG_LLEXT=y
   22  CONFIG_LLEXT_LOG_LEVEL_ERR=y
   23: CONFIG_LLEXT_HEAP_SIZE=32
   24  CONFIG_LLEXT_SHELL=y
   25  CONFIG_LLEXT_STORAGE_WRITABLE=y

~/github/ArduinoCore-zephyr/loader/boards/arduino_nano_33_ble_sense.conf:
   36  CONFIG_SHELL_STACK_SIZE=2048
   37  CONFIG_HEAP_MEM_POOL_SIZE=16384
   38: CONFIG_LLEXT_HEAP_SIZE=96
   39  CONFIG_MAIN_STACK_SIZE=16384
   40  

~/github/ArduinoCore-zephyr/loader/boards/arduino_portenta_h7_m7.conf:
   23  CONFIG_SHELL_STACK_SIZE=32768
   24  CONFIG_MAIN_STACK_SIZE=32768
   25: CONFIG_LLEXT_HEAP_SIZE=128
   26  
   27  #CONFIG_ADC=y

~/github/ArduinoCore-zephyr/variants/arduino_giga_r1_m7/llext-edk/include/zephyr/include/generated/zephyr/autoconf.h:
  414  #define CONFIG_LLEXT 1
  415  #define CONFIG_LLEXT_TYPE_ELF_OBJECT 1
  416: #define CONFIG_LLEXT_HEAP_SIZE 32
  417  #define CONFIG_LLEXT_SHELL 1
  418  #define CONFIG_LLEXT_SHELL_MAX_SIZE 8192

~/github/ArduinoCore-zephyr/variants/arduino_nano_33_ble_sense/llext-edk/include/zephyr/include/generated/zephyr/autoconf.h:
  777  #define CONFIG_LLEXT 1
  778  #define CONFIG_LLEXT_TYPE_ELF_OBJECT 1
  779: #define CONFIG_LLEXT_HEAP_SIZE 96
  780  #define CONFIG_LLEXT_SHELL 1
  781  #define CONFIG_LLEXT_SHELL_MAX_SIZE 8192

~/github/ArduinoCore-zephyr/variants/arduino_portenta_h7/llext-edk/include/zephyr/include/generated/zephyr/autoconf.h:
  567  #define CONFIG_LLEXT 1
  568  #define CONFIG_LLEXT_TYPE_ELF_OBJECT 1
  569: #define CONFIG_LLEXT_HEAP_SIZE 128
  570  #define CONFIG_LLEXT_SHELL 1
  571  #define CONFIG_LLEXT_SHELL_MAX_SIZE 8192

~/github/ArduinoCore-zephyr/variants/ek_ra8d1/llext-edk/include/zephyr/include/generated/zephyr/autoconf.h:
  325  #define CONFIG_LLEXT 1
  326  #define CONFIG_LLEXT_TYPE_ELF_OBJECT 1
  327: #define CONFIG_LLEXT_HEAP_SIZE 32
  328  #define CONFIG_LLEXT_SHELL 1
  329  #define CONFIG_LLEXT_SHELL_MAX_SIZE 8192

~/github/ArduinoCore-zephyr/variants/frdm_mcxn947_mcxn947_cpu0/llext-edk/include/zephyr/include/generated/zephyr/autoconf.h:
  507  #define CONFIG_LLEXT 1
  508  #define CONFIG_LLEXT_TYPE_ELF_OBJECT 1
  509: #define CONFIG_LLEXT_HEAP_SIZE 32
  510  #define CONFIG_LLEXT_SHELL 1
  511  #define CONFIG_LLEXT_SHELL_MAX_SIZE 8192

~/github/zephyr/doc/services/llext/config.rst:
   12  data. The following option controls this allocation.
   13  
   14: :kconfig:option:`CONFIG_LLEXT_HEAP_SIZE`
   15  
   16          Size of the LLEXT heap in kilobytes.

~/github/zephyr/samples/subsys/llext/edk/app/prj.conf:
   12  CONFIG_ZBUS_CHANNEL_NAME=y
   13  
   14: CONFIG_LLEXT_HEAP_SIZE=32
   15  
   16  # Uncomment to disable kext1.

~/github/zephyr/samples/subsys/llext/modules/prj.conf:
   11  CONFIG_LLEXT=y
   12  CONFIG_LLEXT_LOG_LEVEL_DBG=y
   13: CONFIG_LLEXT_HEAP_SIZE=64
   14  CONFIG_LLEXT_TYPE_ELF_RELOCATABLE=y
   15  

~/github/zephyr/samples/subsys/llext/shell_loader/prj.conf:
    9  CONFIG_LLEXT=y
   10  CONFIG_LLEXT_LOG_LEVEL_DBG=y
   11: CONFIG_LLEXT_HEAP_SIZE=8
   12  CONFIG_LLEXT_SHELL=y
   13  

~/github/zephyr/subsys/llext/llext_mem.c:
   26  #endif
   27  
   28: K_HEAP_DEFINE(llext_heap, CONFIG_LLEXT_HEAP_SIZE * 1024);
   29  
   30  /*

~/github/zephyr/tests/subsys/llext/simple/prj.conf:
    3  CONFIG_LOG=y
    4  CONFIG_LLEXT=y
    5: CONFIG_LLEXT_HEAP_SIZE=32
    6  CONFIG_LLEXT_LOG_LEVEL_DBG=y
    7  

~/github/ArduinoCore-zephyr/build/zephyr/.config:
 1317  # CONFIG_LLEXT_TYPE_ELF_RELOCATABLE is not set
 1318  # CONFIG_LLEXT_TYPE_ELF_SHAREDLIB is not set
 1319: CONFIG_LLEXT_HEAP_SIZE=32
 1320  CONFIG_LLEXT_SHELL=y
 1321  CONFIG_LLEXT_SHELL_MAX_SIZE=8192

I am assuming if I change one of these files, I probably at least have to do the
./extras/build.sh

Do I then need to then do the burn bootloader and then rebuild and program the GIGA?

Thanks, I know that this is probably a pain to explain, but then others hopefully will learn as well.
Thanks again

[mjs513]

@facchinm

Just tried your updates in the PR, still getting
[00:00:13.561,000] �[1;31m<err> llext: Failed to copy regions, ret -12�[0m Failed to load sketch, rc -12
even with just trying the QuickStart.ino. Good news is that is the only error I am seeing now that you explained how to use the debugger.

[KurtE]

Quick update: I also tried out using your Pull Request code. I do think some things are working better, I am still having some issues, but learning.

Couple questions and observations:
With current code, the config structure starts off uninitialized (maybe zeros)

private:
  const struct device *spi_dev;
  struct spi_config config;

```'
So if you do something like:

SPI.begin();
SPI.transfer(10);

Nothing is transferred. Whereas I believe most systems are setup to defualt to 4mhz, 8 bit, MSBFIRST.
Which my quick test on the mbed version output/  The Zephyr version did not output anything. 

One hack/fix was in SPI.begin: 
have it do something like:

beginTransaction(SPISettings());
endTransaction();

Or you can unwind the code there.

Side note: on both windows and linux, just before linking I get a message like:
`Bootloader file specified but missing: /home/kurte/Arduino/hardware/arduino-git/ArduinoCore-zephyr/bootloaders/zephyr-arduino_giga_r1_m7.bin
`
Not sure if it is important or not.  The directory bootloaders does not exist. The only  place I notice that directory referenced is in platform.txt

[facchinm]

Answering in order:

temporarily reduce CONFIG_HEAP_MEM_POOL_SIZE to 2048, increase CONFIG_LLEXT_HEAP_SIZE to 64

This requires modifying the loader's .conf for the given board, a run of ./extra/build.sh and a Burn Bootloader to become effective
In general, every modification in loader folder requires this procedure 🙂

SPI does not start with a sensible default

Good catch, preparing a PR for this too

Bootloader missing warning

Not an issue, this will be needed to create a production-ready hex file with loader+sketch in a single flashable .hex file, something for tomorrow 🙂

[mjs513]

temporarily reduce CONFIG_HEAP_MEM_POOL_SIZE to 2048, increase CONFIG_LLEXT_HEAP_SIZE to 64

A bit confused since for the giga_r1 conf those configure parameters are not in the arduino_giga_r1_m7.conf file at all.

Going to add them - deleted what was here because I have had coffee now.

[mjs513]

@facchinm

went ahead and added

CONFIG_HEAP_MEM_POOL_SIZE=2048
CONFIG_LLEXT_HEAP_SIZE=64

No more hangs. Great news but what will the permanent fix be?

Good news is that SPI works but SPI1 works. Probably have to add:

&spi5 {
	status = "okay";
	pinctrl-0 = <&spi5_nss_pk1 &spi5_sck_ph6
		     &spi5_miso_pj11 &spi5_mosi_pj10>;
	pinctrl-names = "default";
};

or something like it.

UPDATE: Added the SPI5 definition just in case but SPI1 is not working with SDfat.

Update2: swapped breadboards just in case. Tested the 2 sketches posted up to 50Mhz and ithey worked.

However, something strange with CS Pin. In one of test sketches I changed the CSpin to pin 6 and it works recognizing the drive and printing sdcard files.

However, if I switch the cspin to pin 10 (no change to sketch) it still works to dump the drive contents even though the sketch specified the CS PIN as 6. Happens if I change the CSPIN in the sketch to other pins. PIN10 is always act as a CSPIN as well as the pin selected.

[KurtE]

I also added the above, and getting some better luck...
@mjs513

However, if I switch the cspin to pin 10 (no change to sketch) it still works to dump the drive contents even though the sketch specified the CS PIN as 6. Happens if I change the CSPIN in the sketch to other pins. PIN10 is always act as a CSPIN as well as the pin selected.

Quick note: with one of the SDFat examples I tried (SDInfo), I found that it appeared to use the

#if HAS_SDIO_CLASS
#define SD_CONFIG SdioConfig(FIFO_SDIO)
#elif ENABLE_DEDICATED_SPI
#define SD_CONFIG SdSpiConfig(SD_CS_PIN, DEDICATED_SPI, SD_SCK_MHZ(16))
#else  // HAS_SDIO_CLASS
#define SD_CONFIG SdSpiConfig(SD_CS_PIN, SHARED_SPI, SD_SCK_MHZ(16))
#endif  // HAS_SDIO_CLASS

ENABLE_DEDICATED_SPI section... Not sure why.
But I edited that section with some deliberate garbage and the compiler errored.

With the display stuff not sure what is going on. I have it setup for SPI1, currently, may try it on SPI
in a minute.

The real simple TFT sketch, runs on it.
simple_tft-241210a.zip

However one where I stripped out stuff from my MBED Giga display code, does not load:
simple_ili9341_GIGA_zephyr-241210a.zip
Note: the monitor setup to Serial1, did catch an issue with missing code, which I resolved.

But once resolved and I try to load the sketch, the monitor window does not show anything
Nor respond, and the Serial object (/dev/ttyACM0) is gone...

EDIT: Forgot to mention that the sketch does run on MBED.
Also not that it is probalby necessary, but I have an ILI9341 display (one from PJRC or Amazon, or Ebay) hooked up to pins SPI (11-13) 10CS 9 DC 8 RST

[mjs513]

@facchinm - @KurtE

Is this going to even be possible using Zephyr, i.e., specifing CS pin to us at run time. Was doing a bit of reading and it appears that you have to identify the pins you will be using for SPI including the CSPin in the overlay file and if you do that you have to recompile the loader etc. Which is not really what you want to do for normal users.

See https://blog.golioth.io/how-to-use-generic-spi-devices-with-zephyr/

there are others but anything I looked was a variation on the theme.

thanks mike

[KurtE]

@mjs513, @facchinm - Not sure about the CS pin, here. That is, you are probably right, if you are trying to setup that
the SPI subsystem actually handles the CS pin for you. But in the Arduino case, mostly the CS pin is driven by the sketch or library directly using standard GPIO pins.

That is, I don't believe the SPI library here does anything with CS pins. In the Teensy SPI code, we do have a method to set a specific pin into SPI CS configuration, but we actually don't have any code in the library that sets the appropriate registers in the hardware to use that pin for hardware CS. However, we do have several libraries that do this, especially on the T3.x boards,

I probably need to look, but I believe that the STM32... has the ability to set SPI to say something like, let GPIO handle this...

I do wonder about, one the spi5(SPI1) object, the .dts file does specify a CS pin (pin 10), wonder if we can/should not specify this
here. The spi1(SPI) object does not describe one as I don't believe that there are not any that are exposed by the hardware.
(But take all of this with a grain of salt!)

[mjs513]

Not sure about the CS pin, here. That is, you are probably right, if you are trying to setup that
the SPI subsystem actually handles the CS pin for you. But in the Arduino case, mostly the CS pin is driven by the sketch or library directly using standard GPIO pins.

That is, I don't believe the SPI library here does anything with CS pins. In the Teensy SPI code, we do have a method to set a specific pin into SPI CS configuration, but we actually don't have any code in the library that sets the appropriate registers in the hardware to use that pin for hardware CS. However, we do have several libraries that do this, especially on the T3.x boards,

I probably need to look, but I believe that the STM32... has the ability to set SPI to say something like, let GPIO handle this...

Take a look at this link. https://devzone.nordicsemi.com/f/nordic-q-a/102776/does-zephyr-spi-apis-support-two-chip-select-pins
and
https://docs.zephyrproject.org/latest/build/dts/api/bindings/spi/nxp,imx-flexspi.html - scroll down to cs-gpios

the Key seems to be you have to set up the overlay to handle multiple cs-pins - 1 per device?