Fix giga display config. #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably a copy&paste error.
The LTDC will have its own SMH option, and the upstream shield config will Not enable this by default.
|
@iabdalkader - I tried bringing this into my current build and it fails to build the variant: Now that I look at it, looks like it failed on the same line in the code checks. as well. Is it maybe supposed to be: CONFIG_STM32_LTDC_FB_NUM ? |
Also this PR may change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SMH will not be enabled for the shield by default, so we need to enable it here. There's also a new option to enable SMH for the display (and configure its attributes) which is used here. This should be merged when zephyrproject-rtos/zephyr#89246 is merged and after an update.
Note this dc22eb9 can probably be reverted. The whole SDRAM can be used for SMH, unless some other drivers use SDRAM outside of SMH (in this case they should also be converted to use SMH).