Skip to content

fix: reimport all the modules before flashing a new FW #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

eigen-value
Copy link
Contributor

Reloading system modules before flashing the carrier firmware ensures that the most recent version of the alvik library is used

@eigen-value eigen-value requested review from ubidefeo and gbr1 November 8, 2024 15:41
Copy link
Member

@gbr1 gbr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ubidefeo please check if it is ok to print the reloading modules at line12

@ubidefeo
Copy link
Contributor

@eigen-value @gbr1

printing the reload message has no real benefit, I'd remove it to prevent the REPL from having non key information

Copy link
Contributor

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of exec but LGTM

@eigen-value
Copy link
Contributor Author

Not a fan of exec but LGTM

Me neither but in this case saves us from keeping track of module names and dependencies

@eigen-value eigen-value merged commit 3dc79de into dev Nov 19, 2024
1 check passed
@gbr1 gbr1 deleted the alvikdev-106 branch November 25, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants