Setting build-path to nested subdirectory

[GeorgeHahn]

Related to #4 - if the build dir is set to a folder within the working directory (eg ./build), a recursive folder structure is created (see #4 for an example).

Issue #4 notes that an error message was added to guard against this behavior. This error message should be extended to cover any folder contained within the working directory.

[matthijskooijman]

Hm, I thought we already fixed this and allowed a build directory within the sketch directory. If not, then it's certainly on my list of things that should be made possible :-)

[luni64]

Any news on that? It still get an error when I define the build directory in the sketch directory
Rel: can't make C:\Users\lutz\source\newProject(1)\bin\core\core.a relative to bin
Any workaround?

[facchinm]

@luni64 would you mind attaching the full compiler output? The problem looks a bit Windows specific

[luni64]

Thanks for your quick reply.

Here the compiler output: output.txt, and here -in case you need the command line parameters- the tasks.json tasks.zip

[facchinm]

Thanks for the log.
I think there might be a workaround by using an absolute path for -build-path= (I would write $PWD/bin on Linux). The piece of code that kicks in is

arduino-builder/phases/linker.go

Lines 58 to 61 in bbf7051

	coreDotARelPath, err := filepath.Rel(buildPath, coreArchiveFilePath)
	if err != nil {
	return i18n.WrapError(err)
	}

For some reason ctx.BuildPath is still relative in that snippet; I'll take a look tomorrow to understand what is happening 🙂

[facchinm]

@luni64 I just pushed a test PR here #308 , as soon as the binary is ready it would be cool if you could test it in your environment!

[luni64]

Sure, I'll test it as soon as it is available

[luni64]

That didn't work, refuses to compile at all now. Here the log:

> Executing task: & 'C:/Program Files/arduino-1.8.5/arduino-builder' -verbose=1 -logger=human '-hardware= C:\Program Files\arduino-1.8.5\hardware' -build-path=bin '-tools=C:\Program Files\arduino-1.8.5\tools-builder' '-tools=C:\Program Files\arduino-1.8.5\hardware\tools\avr' -fqbn=teensy:avr:teensy31:usb=serial,speed=96,opt=o2std,keys=en-us src\main.cpp <

FindFirstFile C:\Users\lutz\source\newProject(1)\ C:\Program Files\arduino-1.8.5\hardware: Die Syntax für den Dateinamen, Verzeichnisnamen oder die Datenträgerbezeichnung ist falsch.
The terminal process terminated with exit code: 1

[facchinm]

@luni64 there's a space between -hardware= and the actual path; I think one of the patches we merged for the commandline (removing the ', ' as separator) made the builder become a bit more picky. May you retest without the space? Thanks!

[luni64]

Thanks, that fixed it. Works perfectly now.

[facchinm]

@luni64 if you could retest the same PR, I changed the place where the fix is applied, there should be no regression but it's better to check before confirming that it works fine 🙂

[luni64]

Thanks again,
just retested it, the new version works as well. I noticed that it generates an additional *.hex file with the BoardName in it? Is there any documentation on the name of the generated output? Looks like it generates

1. sketchname + Extension + hex and
2. sketchname + Extension + BoardID + hex.
   Can I rely on 1) ?