Skip to content

Invalid nightly VersionString causes error during 'lib install' when 'directories' locations do not exist #1196

Closed
@kittaakos

Description

@kittaakos

Bug Report

I got a panic when I wanted to install a lib from ZIP.

Current behavior

akos.kitta@Akoss-MacBook-Pro arduino-cli_nightly-20210224_macOS_64bit % rm -rf ~/Library/Arduino15                                       
akos.kitta@Akoss-MacBook-Pro arduino-cli_nightly-20210224_macOS_64bit % rm -rf ~/Documents/Arduino                                       
akos.kitta@Akoss-MacBook-Pro arduino-cli_nightly-20210224_macOS_64bit % ./arduino-cli version --format json                              
{
  "Application": "arduino-cli",
  "VersionString": "nightly-20210224",
  "Commit": "4c9ce83e",
  "Status": "alpha",
  "Date": "2021-02-24T01:32:19Z"
}
akos.kitta@Akoss-MacBook-Pro arduino-cli_nightly-20210224_macOS_64bit % ./arduino-cli lib install --zip-path ~/Desktop/Tlc5940-0.15.0.zip --verbose
INFO[0000] Config file not found, using default values  
INFO[0000] arduino-cli version nightly-20210224         
INFO[0000] Checking if CLI is Bundled into the IDE      
INFO[0000] Loading hardware from: /Users/akos.kitta/Library/Arduino15/packages 
INFO[0000] Adding libraries dir                          dir=/Users/akos.kitta/Documents/Arduino/libraries location=user
Downloading missing tool builtin:[email protected]...
builtin:[email protected] downloaded                                                                                                                          
INFO[0000] Installing tool                               Tool="builtin:[email protected]"
Installing builtin:[email protected]...
INFO[0000] Tool installed                                Tool="builtin:[email protected]"
builtin:[email protected] installed
Downloading missing tool builtin:[email protected]...
builtin:[email protected] downloaded                                                                                                                       
INFO[0000] Installing tool                               Tool="builtin:[email protected]"
Installing builtin:[email protected]...
INFO[0001] Tool installed                                Tool="builtin:[email protected]"
builtin:[email protected] installed
INFO[0001] Loading hardware from: /Users/akos.kitta/Library/Arduino15/packages 
INFO[0001] Loading package builtin from: /Users/akos.kitta/Library/Arduino15/packages/builtin 
INFO[0001] Checking existence of 'tools' path: /Users/akos.kitta/Library/Arduino15/packages/builtin/tools 
INFO[0001] Loading tools from dir: /Users/akos.kitta/Library/Arduino15/packages/builtin/tools 
INFO[0001] Loaded tool                                   tool="builtin:[email protected]"
INFO[0001] Loaded tool                                   tool="builtin:[email protected]"
WARN[0001] There were errors loading the library index, trying again... 
INFO[0001] Updating libraries index                     
Updating index: library_index.json downloaded                                                                                                                   
INFO[0001] Loading hardware from: /Users/akos.kitta/Library/Arduino15/packages 
INFO[0001] Loading package builtin from: /Users/akos.kitta/Library/Arduino15/packages/builtin 
INFO[0001] Checking existence of 'tools' path: /Users/akos.kitta/Library/Arduino15/packages/builtin/tools 
INFO[0001] Loading tools from dir: /Users/akos.kitta/Library/Arduino15/packages/builtin/tools 
INFO[0001] Loaded tool                                   tool="builtin:[email protected]"
INFO[0001] Loaded tool                                   tool="builtin:[email protected]"
INFO[0001] Adding libraries dir                          dir=/Users/akos.kitta/Documents/Arduino/libraries location=user
INFO[0001] Loading hardware from: /Users/akos.kitta/Library/Arduino15/packages 
INFO[0001] Loading package builtin from: /Users/akos.kitta/Library/Arduino15/packages/builtin 
INFO[0001] Checking existence of 'tools' path: /Users/akos.kitta/Library/Arduino15/packages/builtin/tools 
INFO[0001] Loading tools from dir: /Users/akos.kitta/Library/Arduino15/packages/builtin/tools 
INFO[0001] Loaded tool                                   tool="builtin:[email protected]"
INFO[0001] Loaded tool                                   tool="builtin:[email protected]"
INFO[0001] Adding libraries dir                          dir=/Users/akos.kitta/Documents/Arduino/libraries location=user
INFO[0002] URL: https://downloads.arduino.cc/packages/package_index.json 
INFO[0002] Updating index                                url="https://downloads.arduino.cc/packages/package_index.json"
Updating index: package_index.json downloaded                                                                                                                   
Updating index: package_index.json.sig downloaded                                                                                                               
INFO[0002] Checking signature                            error="opening signature file: open /var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/811020046.sig: no such file or directory" index=/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/811020046 signatureFile=/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/811020046.sig
INFO[0002] Checking signature                            index=/Users/akos.kitta/Library/Arduino15/package_index.json signatureFile=/Users/akos.kitta/Library/Arduino15/package_index.json.sig trusted=true
INFO[0002] Loading hardware from: /Users/akos.kitta/Library/Arduino15/packages 
INFO[0002] Loading package builtin from: /Users/akos.kitta/Library/Arduino15/packages/builtin 
INFO[0002] Checking existence of 'tools' path: /Users/akos.kitta/Library/Arduino15/packages/builtin/tools 
INFO[0002] Loading tools from dir: /Users/akos.kitta/Library/Arduino15/packages/builtin/tools 
INFO[0002] Loaded tool                                   tool="builtin:[email protected]"
INFO[0002] Loaded tool                                   tool="builtin:[email protected]"
INFO[0002] Adding libraries dir                          dir=/Users/akos.kitta/Documents/Arduino/libraries location=user
INFO[0002] Checking signature                            index=/Users/akos.kitta/Library/Arduino15/package_index.json signatureFile=/Users/akos.kitta/Library/Arduino15/package_index.json.sig trusted=true
INFO[0002] Loading hardware from: /Users/akos.kitta/Library/Arduino15/packages 
INFO[0002] Loading package builtin from: /Users/akos.kitta/Library/Arduino15/packages/builtin 
INFO[0002] Checking existence of 'tools' path: /Users/akos.kitta/Library/Arduino15/packages/builtin/tools 
INFO[0002] Loading tools from dir: /Users/akos.kitta/Library/Arduino15/packages/builtin/tools 
INFO[0002] Loaded tool                                   tool="builtin:[email protected]"
INFO[0002] Loaded tool                                   tool="builtin:[email protected]"
INFO[0002] Adding libraries dir                          dir=/Users/akos.kitta/Documents/Arduino/libraries location=user
panic: runtime error: index out of range [1] with length 1

goroutine 1 [running]:
github.com/arduino/arduino-cli/cli/lib.runInstallCommand(0xc0016cb340, 0xc0016c6b70, 0x1, 0x3)
	/home/build/cli/lib/install.go:69 +0x1245
github.com/spf13/cobra.(*Command).execute(0xc0016cb340, 0xc0016c6b40, 0x3, 0x3, 0xc0016cb340, 0xc0016c6b40)
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:846 +0x29d
github.com/spf13/cobra.(*Command).ExecuteC(0xc0000ab8c0, 0x0, 0xc00164d9e0, 0x0)
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:950 +0x349
github.com/spf13/cobra.(*Command).Execute(...)
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:887
main.main()
	/home/build/main.go:31 +0x85
akos.kitta@Akoss-MacBook-Pro arduino-cli_nightly-20210224_macOS_64bit % 

Expected behavior

Environment

  • CLI version (output of arduino-cli version): nightly-20210224
  • OS and platform: macOS 11.2.1

Additional context

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions