Allow case-insensitive ok
or OK
replies from pluggable discoveries and monitors
#1633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)Allow case-insensitive
ok
orOK
replies from pluggable discoveries and monitors.What is the current behavior?
If a discovery or a monitor replies to a command, for example, with:
the answer is treated as an error because it requires a case-sensitive
"OK"
.Also. the error message is completely useless:
What is the new behavior?
The response is accepted for any case-insensitive
ok
/OK
Does this PR introduce a breaking change, and is
titled accordingly?
No breaking changes