Skip to content

Remove useless go.sum and CI check #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

CI enhancement.

What is the current behavior?

go mod tidy is run in CI two times for the root project since term_example only has a go.sum but no go.mod file.

What is the new behavior?

go mod tidy is now run only once for the root project since no check is necessary for term_example as it doesn't have a go.mod file. go.sum for term_example has been removed too.

Does this PR introduce a breaking change, and is titled accordingly?

Nope.

Other information

Change stems from this comment.

@cmaglie cmaglie merged commit bdd0cf9 into arduino:master Oct 20, 2022
@silvanocerza silvanocerza deleted the term_example_module branch October 20, 2022 09:05
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants