Skip to content

[skip-changelog] Eliminate empty lines produced by board details -b #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

CLI imperfection fix

What is the current behavior?

Running board details -b produces unnecessary empty lines between each Required tool entry.

Required tool:             arduino:arm-none-eabi-gcc                                         7-2017q4

Required tool:             arduino:bossac                                                    1.7.0-arduino3

Required tool:             arduino:openocd                                                   0.10.0-arduino7

Required tool:             arduino:CMSIS                                                     4.5.0

Required tool:             arduino:CMSIS-Atmel                                               1.2.0

Required tool:             arduino:arduinoOTA                                                1.2.1

What is the new behavior?

The empty line has been removed and the spacing between the columns reduced. Also, the Programmer's ID is now written in all caps.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

To test the changes, I did not add any new test. However, it was necessary to modify older ones.

Splitting the table produced by `board details` after `Platform checksum` resets both the average length and the variance of the following cells, thus reducing the space between entries.
@MatteoPologruto MatteoPologruto added type: imperfection Perceived defect in any part of project topic: CLI Related to the command line interface labels Dec 1, 2022
@MatteoPologruto MatteoPologruto self-assigned this Dec 1, 2022
@MatteoPologruto MatteoPologruto marked this pull request as ready for review December 1, 2022 09:48
@MatteoPologruto MatteoPologruto linked an issue Dec 1, 2022 that may be closed by this pull request
@MatteoPologruto MatteoPologruto merged commit 210dda4 into arduino:master Dec 1, 2022
@MatteoPologruto MatteoPologruto deleted the board-details-spacing branch December 1, 2022 09:53
@per1234 per1234 added the topic: code Related to content of the project itself label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undesired empty lines when executing board details -b
3 participants