Skip to content

Allow non-cgo builds for Darwin #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 13, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Allow build without CGO enabled for darwin.

What is the current behavior?

What is the new behavior?

Language detection using MacOS APIs is disabled for non-CGO builds on darwin.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 13, 2023
@cmaglie cmaglie self-assigned this Jun 13, 2023
@cmaglie cmaglie requested a review from umbynos June 13, 2023 14:11
@cmaglie cmaglie changed the title Allow non-cgo builds for Dawrin Allow non-cgo builds for Darwin Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (422a42c) 62.98% compared to head (6eb0ecf) 62.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2213      +/-   ##
==========================================
- Coverage   62.98%   62.92%   -0.07%     
==========================================
  Files         218      218              
  Lines       19466    19466              
==========================================
- Hits        12261    12249      -12     
- Misses       6122     6131       +9     
- Partials     1083     1086       +3     
Flag Coverage Δ
unit 62.92% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
i18n/detect_cgo_darwin.go 80.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie merged commit 5725c02 into master Jun 13, 2023
@cmaglie cmaglie deleted the allow_non_cgo_build_for_darwin branch June 13, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants