Skip to content

Remove debug prints #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Remove debug prints #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion arduino/cores/packageindex/index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ func LoadIndex(jsonIndexFile *paths.Path) (*Index, error) {
if err != nil {
return nil, err
}
//fmt.Println(string(buff))
var index Index
err = json.Unmarshal(buff, &index)
if err != nil {
Expand Down
2 changes: 0 additions & 2 deletions arduino/cores/packageindex/index_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
package packageindex

import (
"fmt"
"testing"

"github.com/arduino/go-paths-helper"
Expand All @@ -35,7 +34,6 @@ func TestIndexParsing(t *testing.T) {
if indexFile.Ext() != ".json" {
continue
}
fmt.Println("Loading:", indexFile)
_, err := LoadIndex(indexFile)
require.NoError(t, err)
}
Expand Down
1 change: 0 additions & 1 deletion arduino/cores/packagemanager/package_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ func TestBoardOptionsFunctions(t *testing.T) {
func TestFindToolsRequiredForBoard(t *testing.T) {
os.Setenv("ARDUINO_DATA_DIR", dataDir1.String())
configuration.Init("")
fmt.Println(viper.AllSettings())
pm := packagemanager.NewPackageManager(
dataDir1,
configuration.PackagesDir(),
Expand Down
1 change: 0 additions & 1 deletion cli/cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ func detectLatestAVRCore(t *testing.T) string {
}
}
require.NotEmpty(t, latest, "latest avr core version")
fmt.Println("Latest AVR core version:", latest)
return latest.String()
}

Expand Down
2 changes: 0 additions & 2 deletions commands/daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ package daemon

import (
"context"
"fmt"
"io"
"net/http"

Expand Down Expand Up @@ -116,7 +115,6 @@ func (s *ArduinoCoreServerImpl) Init(req *rpc.InitReq, stream rpc.ArduinoCore_In
if err != nil {
return err
}
fmt.Println(resp)
return stream.Send(resp)
}

Expand Down
3 changes: 0 additions & 3 deletions commands/daemon/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import (
"context"
"encoding/json"
"errors"
"fmt"

rpc "github.com/arduino/arduino-cli/rpc/settings"
"github.com/spf13/viper"
Expand Down Expand Up @@ -62,8 +61,6 @@ func (s *SettingsService) GetValue(ctx context.Context, req *rpc.GetValueRequest
key := req.GetKey()
value := &rpc.Value{}

fmt.Println(viper.AllKeys())

if !viper.InConfig(key) {
return nil, errors.New("key not found in settings")
}
Expand Down
2 changes: 0 additions & 2 deletions commands/daemon/settings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ package daemon
import (
"context"
"encoding/json"
"fmt"
"testing"

"github.com/spf13/viper"
Expand Down Expand Up @@ -54,7 +53,6 @@ func TestMerge(t *testing.T) {
_, err := svc.Merge(context.Background(), &rpc.RawData{JsonData: bulkSettings})
require.Nil(t, err)

fmt.Println(viper.AllSettings())
require.Equal(t, "420", viper.GetString("daemon.port"))
require.Equal(t, "bar", viper.GetString("foo"))

Expand Down
1 change: 0 additions & 1 deletion commands/instances.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ func Init(ctx context.Context, req *rpc.InitReq, downloadCB DownloadProgressCB,
instances[handle] = instance

if err := instance.checkForBuiltinTools(downloadCB, taskCB, downloaderHeaders); err != nil {
fmt.Println(err)
return nil, err
}

Expand Down
2 changes: 0 additions & 2 deletions legacy/builder/test/includes_to_include_folders_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
package test

import (
"fmt"
"path/filepath"
"sort"
"testing"
Expand Down Expand Up @@ -331,7 +330,6 @@ func TestIncludesToIncludeFoldersSubfolders(t *testing.T) {

importedLibraries := ctx.ImportedLibraries
sort.Sort(ByLibraryName(importedLibraries))
fmt.Println(importedLibraries)
require.Equal(t, 3, len(importedLibraries))
require.Equal(t, "testlib1", importedLibraries[0].Name)
require.Equal(t, "testlib2", importedLibraries[1].Name)
Expand Down
1 change: 0 additions & 1 deletion legacy/builder/tools_loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ type ToolsLoader struct{}

func (s *ToolsLoader) Run(ctx *types.Context) error {
if ctx.CanUseCachedTools {
//fmt.Println("no fs modification, can use cached ctx")
return nil
}

Expand Down