GH-680: Reduced the log level in package manager #774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on, we log with the
debug
level instead ofinfo
. Without this change, the daemon log was full of this information when customing the CLI features via gRPC.Closes #680
Signed-off-by: Akos Kitta [email protected]
Please check if the PR fulfills these requirements
Reduces the log-level of the package-manager from
info
todebug
Now, when I consume the CLI in the Pro IDE, I do not see the daemon log full of:
I have verified it with a local CLI build against the
0.11.0
tag.n/a
No. I hope no clients are parsing the stdout of the daemon.
The fix is not urgent for the Pro IDE. We have to do filtering on our side too anyways; the CLI version is pinned to
0.11.0
so we cannot use this fix.See how to contribute