Skip to content

GH-680: Reduced the log level in package manager #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

kittaakos
Copy link
Contributor

From now on, we log with the debug level instead of info. Without this change, the daemon log was full of this information when customing the CLI features via gRPC.

Closes #680

Signed-off-by: Akos Kitta [email protected]


Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Reduces the log-level of the package-manager from info to debug

  • What is the current behavior?

Now, when I consume the CLI in the Pro IDE, I do not see the daemon log full of:

[INFO] current best: arduino:[email protected] [bundle: false, managed: true, version: 1.8.2]
[INFO] current best: arduino:[email protected] [bundle: false, managed: true, version: 1.8.2]
[INFO] current best: arduino:[email protected] [bundle: false, managed: true, version: 1.8.2]
[INFO] current best: arduino:[email protected] [bundle: false, managed: true, version: 1.8.2]

I have verified it with a local CLI build against the 0.11.0 tag.

  • What is the new behavior?

n/a

  • Does this PR introduce a breaking change?

No. I hope no clients are parsing the stdout of the daemon.

  • Other information:

The fix is not urgent for the Pro IDE. We have to do filtering on our side too anyways; the CLI version is pinned to 0.11.0 so we cannot use this fix.


See how to contribute

From now on, we log with the `debug` level instead of `info`.

Closes arduino#680

Signed-off-by: Akos Kitta <[email protected]>
@cmaglie cmaglie merged commit 44e3ce1 into arduino:master Jul 1, 2020
@kittaakos kittaakos deleted the GH-680 branch July 1, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants