Skip to content

If installer can't run post_install do not give up #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2020
Merged

If installer can't run post_install do not give up #912

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea8b247
Changed core install message
cmaglie Aug 20, 2020
a8fdb31
Removed useless condition (letfover)
cmaglie Aug 20, 2020
a9c241f
Convert errors running post_install into warnings
cmaglie Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions commands/core/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,13 @@ func installPlatform(pm *packagemanager.PackageManager,
// Perform post install
if !skipPostInstall {
log.Info("Running post_install script")
taskCB(&rpc.TaskProgress{Message: "Configuring platform (post_install run)"})
taskCB(&rpc.TaskProgress{Message: "Configuring platform"})
if err := pm.RunPostInstallScript(platformRelease); err != nil {
return errors.Errorf("running post install: %s", err)
taskCB(&rpc.TaskProgress{Message: fmt.Sprintf("WARNING: cannot run post install: %s", err)})
}
} else if skipPostInstall {
} else {
log.Info("Skipping platform configuration (post_install run).")
taskCB(&rpc.TaskProgress{Message: "Skipping platform configuration (post_install run)"})
taskCB(&rpc.TaskProgress{Message: "Skipping platform configuration"})
}

log.Info("Platform installed")
Expand Down