Skip to content

[skip changelog] Remove monitor test in daemon mode #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2020
Merged

[skip changelog] Remove monitor test in daemon mode #937

merged 2 commits into from
Sep 4, 2020

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Sep 4, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

This PR removes gRPC serial monitor tests

  • Does this PR introduce a breaking change?

No

  • Other information:

Solves #740
A more meaningful test will be created in a separate PR, that will leverage python e2e tests and/or our gRPC Client Example

See how to contribute

@rsora rsora merged commit 09b4e88 into master Sep 4, 2020
@rsora rsora deleted the rsora/monitor-test-remove branch September 4, 2020 16:47
@rsora
Copy link
Contributor Author

rsora commented Sep 4, 2020

Solve #740

@rsora rsora mentioned this pull request Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsora @cmaglie