`Ino` icon is missing from the editor tabs

[kittaakos]

Describe the problem

I can see the ino icon in the editor tabs on Windows, it's missing on macOS. I did not even notice this earlier.

macOS:

Windows:

To reproduce

Open the IDE2.

Expected behavior

ino icon is in the editor tab on macOS

Arduino IDE version

Version: 2.0.0-rc8-nightly-20220711 Date: 2022-07-11T03:32:37.503Z CLI Version: 0.24.0 [c1b10f56] Copyright © 2022 Arduino SA

Operating system

macOS

Operating system version

12.3.1

Additional context

No response

Issue checklist

• I searched for previous reports in the issue tracker
• I verified the problem still occurs when using the latest nightly build
• My report contains all necessary details

[kittaakos]

One has to enable the "workbench.iconTheme" preference key, then the icon is there, and the error decorator is also available.

Are we good with the default, not showing icons in IDE2 behavior? What do you think, @per1234? Thank you!

[per1234]

I'm feeling very indecisive.

In the most common use case:

• Only .ino files are open in the IDE
• arduino.language.realTimeDiagnostics is disabled

the Arduino logo icons feel redundant ("yes, I already know I'm using the Arduino IDE") and like they are only taking up space on the editor tabs bar:

However, in the more advanced use case where several file types are open in the editor, and especially in the even more advanced use case where arduino.language.realTimeDiagnostics is enabled, I think it is valuable:

[kittaakos]

Thank you!

Let's leave it as is now without icons and no error decorations.

To enable the feature:

• Open the Command Palette with F1,
• Search for Preferences: File Icon Theme, press Enter
• Select File Icons (Theia), press Enter

Or put "workbench.iconTheme": "theia-file-icons" to the ~/.arduinoIDE/settings.json file.

enable_file_icons.mp4