Remove deprecated Theia themes

[per1234]

Describe the request

• Remove the "Dark (Theia)" and "Light (Theia)" themes from the "Theme" menu of the Arduino IDE Preferences dialog.
• Remove the then unnecessary suffixes from the text of the "Theme" menu:
  • High Contrast (Theia) -> High Contrast
  • Dark (Arduino) -> Dark
  • Light (Arduino) -> Light

🙂 Users will not be offered superfluous unsupported theme options.

Describe the current behavior

Arduino IDE 2.x is built on the free open source Eclipse Theia IDE framework. The Theia project provides several themes:

• Dark (Theia)
• Light (Theia)
• High Contrast (Theia)

Arduino has created bespoke themes which carry forward and expand the distinctive Arduino design style into this new release of the Arduino IDE:

• Dark (Arduino)
• Light (Arduino)

All five of these themes are currently listed under the "Theme" menu of the Arduino IDE Preferences dialog.

Since Arduino's themes are functional replacements for the dark and light Theia themes, development resources are more effectively allocated to other aspects of the project than to supporting and maintaining Theia's themes. For this reason, the "Dark (Theia)" and "Light (Theia)" themes are deprecated and no longer supported by Arduino (the high contrast theme continues to be supported since this potentially provides unique value in improving accessibility).

🙁 Users are offered theme options which have known problems and will not be supported. The maintenance burden of the Arduino IDE project is increased by the need to manage defect reports or enhancement requests we can not resolve.

Arduino IDE version

2.0.0-rc9.1-snapshot-d556ee9

Operating system

All

Issue checklist

• I searched for previous requests in the issue tracker
• I verified the feature was still missing when using the latest nightly build
• My request contains all necessary details

[InstantMuffin]

Thank you for referencing this.
Switching from Theia Light to Theia Arduino gives an "aha"-moment and gives sense to a lot of design choices (especially the icons in the top right corner) I have observed during my use of the release candidates.
I hope the old themes get removed soon because to me as a user it was not known that these are deprecated, and from a dev perspective the term seems odd to use. With the backstory of them being Theia's default themes (and Theia being an IDE framework and not a fancy old Greek name for a theme) their existence makes sense.

I hope that during that transition Arduino IDE reads the config files and selects the respective light and dark themes based on the user's Theia default theme choice.

If for some reason this transition can't be done easily, in the meantime I would love for these deprecated themes to have remark in their name in the theme listbox in the settings so users know what is going on and might transition on their own, improving the user experience and reducing possible bug reports.

[InstantMuffin]

Like this:

I tried to find the respective themes in this repo but was unsuccessful and could only find things related to the themes the arduino-ide adds themself.

EDIT: Using offline search I find the respective labels in "bundle.js" in "/browser-app/lib" and "/electron-app/lib" and in the theia node modules. These are mostly huge files which is why I think github search doesn't touch them.
Without any background knowledge, I am still getting the feeling these aren't supposed to be touched judging by filename and size and I'm looking at the wrong places here.

[kittaakos]

The Theia theme files come from Theia. IDE2 uses @theia/monaco@1.25.0. The files are here on GitHub: light_theia.json and dark_theia.json. In the bundled app, they're in the final bundle.js. In the IDE2 code, they get registered here.

[Willem43T]

I use the Dark (Theia) and like the color blend. I would have prefered a slightly more "greyish" dark than "brownish - redish?" dark (on my monitor) for the background) but am OK with the current one.

I really dislike the Dark (Arduino) theme (way to much sh...y "orangey" text) so would not like the Theia one be removed.

[AdamKnube]

I use the Dark (Theia) and like the color blend. I would have prefered a slightly more "greyish" dark than "brownish - redish?" dark (on my monitor) for the background) but am OK with the current one.

I really dislike the Dark (Arduino) theme (way to much sh...y "orangey" text) so would not like the Theia one be removed.

I totally agree with Will, but for another reason.
I'm have vision issues when it comes to colours.
As such when I enable the Android Dark theme I caanot see my cursor when navigating selected text.
To me the cursor and the selection cannot be told apart.
However using the Theia theme changes the cursor to white and the selection to blue which i can tell apart.
So I'm asking that if you do remove the Theia themes then can we at least get a white cursor with it?
Cheers.