Skip to content

IDE2's settings model gets out of sync from the persisted values of the Theia preferences #1987

Closed
@kittaakos

Description

@kittaakos

Describe the problem

When I change the font size + interface scale settings with a keybinding and the theme from the command palette, the settings model gets out of sync.

To reproduce

  • Select a theme that is different from your currently selected one from the command palette with the Ctrl/⌘+K Ctrl/⌘+T key-chord. Confirm your selection with Enter—the theme changes.
  • Increase the font size with Ctrl/⌘+=. The font size changes, but the theme reverts to the previous one.
settings_out_of_sync.mp4

Another use-case:

  • Open settings dialog,
  • Change the theme with the command palette,
  • The theme <select> does not change in the dialog,
  • Press OK or Cancel, the theme reverts.
settings_dialog_out_of_sync_01.mp4
settings_dialog_out_of_sync_02.mp4

Expected behavior

The IDE2's settings model is in sync with the Theia preferences:

  • After changing the theme from the command palette, changing the interface scale via the keyboard does not revert the theme change.
  • When the settings dialog is opened, the theme <select> reflects the current IDE2 theme:
    • Pressing Cancel reverts to the theme which was active before opening the settings dialog,
    • Pressing OK keeps the selected theme.

Arduino IDE version

2.0.4

Operating system

macOS

Operating system version

12.6.3

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions