Skip to content

Unsaved changes are lost on "Language" preference change #954

Open
@per1234

Description

@per1234

Describe the problem

The "Language" menu of the File > Preferences dialog now offers a selection of seven languages the Arduino IDE user interface can be localized to (#941).

🐛 Any unsaved changes to the sketch are lost after changing this preference.

To reproduce

  1. Select File > Preferences... from the Arduino IDE menus.
  2. Uncheck the box next to " Auto save".
  3. Click the OK button.
  4. Make some change to the sketch.
    ❗ Do not save the sketch.
  5. Select File > Preferences... from the Arduino IDE menus.
  6. Select a different language from the "Language" menu.
  7. Click the OK button.

🐛 The unsaved change to the sketch is lost when the IDE window reloads.

Expected behavior

Make the unsaved state of the sketch persist through the reload.

-OR-

Present the user with a standard save dialog before doing the reload.

Arduino IDE version

2.0.0-rc5-snapshot-a3640cf

Operating system

Windows, Linux

Operating system version

Windows 10, Ubuntu 20.04

Additional context

I think this will occur for any preference that causes a reload on change, but I didn't find any others that have that behavior currently.


This was not introduced by #953. The unsaved changes were lost even with the reload method used before the change made in that PR.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details

Metadata

Metadata

Assignees

Labels

topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions