Skip to content

#979 fix platform installation prompt only made for boards listed in oldest release #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2022
Merged

#979 fix platform installation prompt only made for boards listed in oldest release #1131

merged 1 commit into from
Jul 4, 2022

Conversation

davegarthsimpson
Copy link
Contributor

@davegarthsimpson davegarthsimpson commented Jun 30, 2022 •
edited
Loading

Motivation

Users have reported that selecting certain boards; for which a platform is not installed, erroneously fails to show an auto-install prompt.

Change description

Inverts the comparator used when sorting uninstalled packages, without affecting fqbn information in platform search results. Other changes are simple code quality cleanup.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@davegarthsimpson davegarthsimpson changed the title invert uninstalled pkg comparator + cleanup #979 fix platform installation prompt only made for boards listed in oldest release Jun 30, 2022
@per1234 per1234 linked an issue Jul 1, 2022 that may be closed by this pull request
Platform installation prompt only made for boards listed in oldest release #979
Closed
3 tasks
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 1, 2022
per1234
per1234 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #979

Thanks Dave!

kittaakos
kittaakos approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davegarthsimpson davegarthsimpson merged commit 9538598 into main Jul 4, 2022
@davegarthsimpson davegarthsimpson deleted the 979-platform-install-prompt branch July 4, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

@per1234 per1234 per1234 approved these changes

@fstasi fstasi Awaiting requested review from fstasi

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Platform installation prompt only made for boards listed in oldest release
3 participants
@davegarthsimpson @kittaakos @per1234