Skip to content

Increase sketchbook tree indentation to reflect design system #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2022
Merged

Increase sketchbook tree indentation to reflect design system #1148

merged 2 commits into from
Jul 5, 2022

Conversation

francescospissu
Copy link
Contributor

Motivation

The indentation of the sketchbook tree must be increased even more in order to reflect the design system.

Change description

Increase the padding.

Before:
Screenshot 2022-07-05 110725

After:
Screenshot 2022-07-05 111227

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@francescospissu francescospissu added type: enhancement Proposed improvement topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 5, 2022
@francescospissu francescospissu requested a review from 91volt July 5, 2022 09:19
91volt
91volt previously approved these changes Jul 5, 2022
View reviewed changes
@AlbyIanna AlbyIanna self-requested a review July 5, 2022 10:00
@91volt 91volt dismissed their stale review July 5, 2022 10:19

not fixed when "show file inside sketches" is disabled

AlbyIanna
AlbyIanna suggested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work well when the Show files inside Sketches option is disabled.

Screenshot 2022-07-05 at 12 14 48

@francescospissu
Copy link
Contributor Author

@AlbyIanna you're right, I set the correct padding value here.

AlbyIanna
AlbyIanna approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @francescospissu, now they look perfect 🌻

@francescospissu francescospissu merged commit b1e00e6 into main Jul 5, 2022
@francescospissu francescospissu deleted the fspissu/indentation-fix branch July 5, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@91volt 91volt 91volt left review comments

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francescospissu @AlbyIanna @91volt