Register custom themes after the monaco theme init #1257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update from the The changes should contain the app config provider customization. See here. The content of the |
AlbyIanna
force-pushed
the
fix-themes-registration
branch
from
97e1b1f to
0d84164
Compare
kittaakos
suggested changes
Jul 28, 2022
AlbyIanna
force-pushed
the
fix-themes-registration
branch
from
0d84164 to
f448065
Compare
Signed-off-by: Akos Kitta <[email protected]>
AlbyIanna
force-pushed
the
fix-themes-registration
branch
from
f448065 to
86c5fb1
Compare
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the Arduino custom theme registration happens before the restoration of the existing monaco themes, then any custom theme changes will be ignored.
Change description
We need to add a patch introduces a static deferred promise in the monaco-theming service that will be resolved when the restoration is ready.
After upgrading to Theia 1.27.0, this patch should be superflous.
Other information
The credit for this solution goes to @kittaakos
Reviewer checklist