Skip to content

#1404 Serial Monitor message history #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

#1404 Serial Monitor message history #1453

wants to merge 4 commits into from

Conversation

dwightfowler-cd
Copy link
Contributor

Motivation

Close #1404

Change description

Implement history for Serial Monitor input using up-arrow / down-arrow.

Other information

N/A

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@dwightfowler-cd
Copy link
Contributor Author

My apologies for commit 26dc4c5 and 7851637. I forgot that PRs into my personal main branch get added over here at arduino/arduino-ide.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor labels Sep 17, 2022
@kittaakos kittaakos changed the title Implement Issue #1404 #1404 Serial Monitor message history Sep 19, 2022
kittaakos
kittaakos reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution; I added a few remarks and am happy to try out your changes after your updates.

@dwightfowler-cd dwightfowler-cd mentioned this pull request Sep 19, 2022
Closed
4 tasks
@kittaakos
Copy link
Contributor

@dwightfowler-cd, thank you for the updates. You have opened a new PR instead of updating this one. Which one do you want me to review? Can you create one PR instead of opening a new one for each commit?

@kittaakos
Copy link
Contributor

Closing in favor of #1467.

@kittaakos kittaakos closed this Sep 21, 2022
@kittaakos kittaakos added the conclusion: duplicate Has already been submitted label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos left review comments

Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serial Monitor message history
3 participants
@dwightfowler-cd @kittaakos @per1234