Skip to content

Avoid new line if 3rd party URLs text is too long #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2022
Merged

Avoid new line if 3rd party URLs text is too long #1474

merged 1 commit into from
Sep 21, 2022

Conversation

francescospissu
Copy link
Contributor

Motivation

In the "Additional Boards Manager URLs" dialog, if the text of a 3rd party URL is too long, it is returned in a new line. See description here.

Change description

Avoid new line adding white-space: nowrap; CSS rule.

Result:

sketch_jun14a._.Arduino.IDE.2.0.0.2022-09-21.11-06-41.mp4

Other information

Closes #1470.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@francescospissu francescospissu added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 21, 2022
@francescospissu francescospissu self-assigned this Sep 21, 2022
kittaakos
kittaakos approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@francescospissu francescospissu merged commit 42f6f43 into main Sep 21, 2022
@francescospissu francescospissu deleted the fspissu/one-line-urls branch September 21, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees

@francescospissu francescospissu

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3rd party URLs dialog should not wrap text
2 participants
@francescospissu @kittaakos