Skip to content

Avoid intellisense widgets being covered by the bottom panel #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

r3inbowari
Copy link
Contributor

Motivation

Avoid the problem that the Intellisense widget may be cover by the bottom(Output) panel partially.

Change description

from:
image

to:
image

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2022

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added the topic: code Related to content of the project itself label Sep 21, 2022
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @r3inbowari!

Your change fixes the issue, although I would prefer increasing the z-index of the #theia-main-content-panel instead of setting a negative value for the #theia-bottom-content-panel. This way, we make sure that any sibiling of the main content panel will have a lower z-index than its own – for example, in the situation we add a new widget there, we would incur in the same issue again.

Something like this should work:

#theia-main-content-panel {
  z-index: 1
}

@r3inbowari
Copy link
Contributor Author

Agree :) Also fixed SplitPanel-handle showing above intellisense widget.

from:
1663842466981

to:
1663842423909

@AlbyIanna
Copy link
Contributor

This looks even better! I tested it and it works perfectly 😺
Thank you so much!

@AlbyIanna AlbyIanna added the type: imperfection Perceived defect in any part of project label Sep 22, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @r3inbowari!

@per1234 per1234 merged commit d6cb23f into arduino:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants