Skip to content

bump arduino-fwuploader to 2.2.2 #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

bump arduino-fwuploader to 2.2.2 #1584

merged 1 commit into from
Oct 27, 2022

Conversation

AlbyIanna
Copy link
Contributor

Motivation

Bump arduino-fwuploader to version 2.2.2

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

kittaakos
kittaakos previously requested changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at the end of file

The version update is OK.

@AlbyIanna AlbyIanna requested a review from kittaakos October 27, 2022 12:24
@AlbyIanna
Copy link
Contributor Author

no newline at the end of file

My bad, my editor settings was misconfigured.

I changed it, please review it again.

@AlbyIanna AlbyIanna requested review from kittaakos and removed request for kittaakos October 27, 2022 12:51
@AlbyIanna AlbyIanna dismissed kittaakos’s stale review October 27, 2022 12:53

the change has been addressed and approved by Dave

@AlbyIanna AlbyIanna merged commit 4e882d2 into main Oct 27, 2022
@AlbyIanna AlbyIanna deleted the bump-fwuploader branch October 27, 2022 12:53
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davegarthsimpson davegarthsimpson davegarthsimpson approved these changes

@per1234 per1234 Awaiting requested review from per1234

@kittaakos kittaakos Awaiting requested review from kittaakos

Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlbyIanna @kittaakos @davegarthsimpson @per1234