Skip to content

feat: moved login entry point to the side-bar #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2023
Merged

feat: moved login entry point to the side-bar #1881

merged 1 commit into from
Feb 20, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Feb 10, 2023

Motivation

Moved the Arduino Cloud login from the tree to the sidebar.

Change description

New login location:

1877.mp4

Other information

Closes #1877

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 10, 2023
@per1234 per1234 linked an issue Feb 11, 2023 that may be closed by this pull request
3 tasks
@kittaakos
Copy link
Contributor Author

@91volt, I have noticed the followings:

  • Use Learn More instead of Learn more in the UI if IDE2 wants to follow to command label naming convention.
  • Use Sign in to Arduino Cloud instead of Sign in with Arduino Cloud.
    What do you think?

@kittaakos
Copy link
Contributor Author

kittaakos commented Feb 13, 2023

@91volt, I also need instructions on where the Go to Profile leads. Thank you!

I know that the profile page URL is https://id.arduino.cc/. When I log in with SSO in the browser and navigate to this page, it loads my profile.

Problem: an IDE2 user might be logged in with a different account in IDE2 than the browser, so navigating to the https://id.arduino.cc location from IDE2 can be incorrect.

@kittaakos kittaakos marked this pull request as ready for review February 13, 2023 10:14
@kittaakos kittaakos self-assigned this Feb 15, 2023
Base automatically changed from #1825 to main February 15, 2023 13:09
Copy link

@91volt 91volt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittaakos lgtm

  • My take is that the writing rules needs to be better defined, for now is ok leaving it as implemented
  • Fine with me "Sign to Arduino Cloud"
  • The Cloud Sketchbook doesn't provide features to handle multiple accounts for now, considering that is ok redirecting to the generic id.arduino.cc when the user click on "Go to profile".

@kittaakos
Copy link
Contributor Author

  • My take is that the writing rules needs to be better defined, for now is ok leaving it as implemented

Can you please explain what you mean? Thanks!

@91volt
Copy link

91volt commented Feb 20, 2023

Can you please explain what you mean? Thanks!

I haven't found any Arduino guidelines on label conventions, it is a topic that needs to be addressed with other teams.
Looking into other labelling conventions it looks like all the other internal words should begins with lowercase (reference).
So my take is to leave it as you implemented it, since there are no clear rules right now.

@kittaakos kittaakos merged commit 4deaf4f into main Feb 20, 2023
@kittaakos kittaakos deleted the #1877 branch February 20, 2023 16:30
@per1234 per1234 added the topic: cloud Related to Arduino Cloud and cloud sketches label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Cloud "Login entry point" to the sidebar of IDE2
3 participants