Skip to content

ATL-786: Progress indication for install. #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

ATL-786: Progress indication for install. #305

merged 1 commit into from
Apr 9, 2021

Conversation

kittaakos
Copy link
Contributor

This PR gets rid of the modal dialogs when installing/uninstalling libs and platforms.

Signed-off-by: Akos Kitta [email protected]

@kittaakos kittaakos force-pushed the install-with-progress branch from 6a73507 to e48def5 Compare April 9, 2021 12:45
@silvanocerza
Copy link
Contributor

Just tested and I like this enhancement, my only concern is that probably the bar might be too small, could it be made a bit thicker or the size is fixed?

@kittaakos
Copy link
Contributor Author

ould it be made a bit thicker or the size is fixed?

Yes, we can do that. Also, the default color should not be the hardcoded blue from Theia but aligned with the status bar color. I think it is blue.

I wanted to reset the progress bar between the tasks (there is no progress for tasks, only for downloads), and use an unknonwk progress indicator, but it does not seem to work. (Related: eclipse-theia/theia#9323)

@kittaakos
Copy link
Contributor Author

Yes, we can do that.

and use an unknonwk progress indicator

I have updated the PR. Here it is in action. Now, the progress bar can jump between unknown and normal mode:

screencast 2021-04-09 16-56-21

@kittaakos kittaakos force-pushed the install-with-progress branch from e48def5 to 54cf4b0 Compare April 9, 2021 15:00
silvanocerza
silvanocerza approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, it's so much better now!

@kittaakos kittaakos force-pushed the install-with-progress branch from 54cf4b0 to 85059a9 Compare April 9, 2021 15:25
@kittaakos kittaakos force-pushed the install-with-progress branch from 85059a9 to 54e5746 Compare April 9, 2021 15:33
@kittaakos kittaakos changed the title Added progress for install/uninstall. ATL-786: Progress indication for install. Apr 9, 2021
@kittaakos
Copy link
Contributor Author

I am merging this into the other PR.

@kittaakos kittaakos merged commit 8e16c7e into atl-1195--show-all-examples-when-no-board-selected Apr 9, 2021
@kittaakos kittaakos deleted the install-with-progress branch April 9, 2021 15:40
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Oct 25, 2021
This was referenced Oct 25, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittaakos @silvanocerza @per1234