Skip to content

Fixed workspace variable resolver. Can start debug session multiple times from the toolbar. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fixed workspace variable resolver. Can start debug session multiple times from the toolbar. #50

merged 1 commit into from
Mar 3, 2021

Conversation

kittaakos
Copy link
Contributor

Fall back to the current sketch, if currentWidget points to a file
outside of the workspace.

Closes: #46
Signed-off-by: Akos Kitta [email protected]

How to test:

  • You should be able to start/stop as many consecutive debug sessions from the toolbar as you pleased.

Fixed workspace variable resolver.
c1550ef 
Fall back to the current sketch, if `currentWidget` points to a file
outside of the workspace.

Closes: #46

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos requested a review from ubidefeo March 1, 2021 10:56
per1234
per1234 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to reproduce #46 when using 2.0.0-beta3. The issue does not occur when using the test build from this PR.

@kittaakos kittaakos merged commit acbd98d into main Mar 3, 2021
@kittaakos kittaakos deleted the atl-972--debug-remove-theia-folder branch March 3, 2021 10:53
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: debugger Related to the integrated debugger labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

Assignees
No one assigned
Labels
topic: code Related to content of the project itself topic: debugger Related to the integrated debugger type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debugger restart error if debug icon is pressed after a stop
2 participants
@kittaakos @per1234