Allow ISO8859-1 encoding in properties #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
.properties
file is parsed as UTF-8 encoded, but if we found some non UTF-8 characters, we now assume it's ISO8859-1 and we convert it back to UTF-8. It is common to find ISO8859-1 encoded.properties
files in old java projects.ISO8859-1 range is 0x00-0xFF so the conversion is done by simply converting each byte in the corresponding code point in UTF-8: https://stackoverflow.com/a/13511463/1655275