Made writes to output stream synchronous #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
force-pushed
the
remove_channels
branch
from
3010c56 to
53a1b51
Compare
This ensures that the discovery outputs the `quit` message before quitting, without the extra complexity of channel synchronization.
cmaglie
force-pushed
the
remove_channels
branch
2 times, most recently
from
7012a44 to
6bda725
Compare
cmaglie
force-pushed
the
remove_channels
branch
from
6bda725 to
15436b2
Compare
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 4 4
Lines 263 253 -10
=====================================
+ Misses 263 253 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
umbynos
added
type: enhancement
umbynos
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the discovery outputs the
quitmessage before quitting, without the extra complexity of channel synchronization.Also updated the workflow to validate TaskFile.yml.
Also updated the CODECOV workflow by adding the token to reduce upload failures due to API limits.