Skip to content

Can start the LS without an Output channel. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Conversation

kittaakos
Copy link
Contributor

The Arduino LS can be started without the OutputChannel support.

IDE2 will start the LS with the new silentOutput: true option. This should help IDE2's UI. UX-wise, it's no change for the users.

Ref: arduino/arduino-ide#714

Signed-off-by: Akos Kitta [email protected]

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 27, 2022
Copy link

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked, LGTM

@kittaakos kittaakos merged commit 2c458f1 into main Jul 28, 2022
@kittaakos kittaakos deleted the silent-output-signed branch January 10, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants