Skip to content

The scope of the unsafe block can be appropriately reduced #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2022
Merged

The scope of the unsafe block can be appropriately reduced #319

merged 2 commits into from
Sep 11, 2022

Conversation

peamaeq
Copy link
Contributor

@peamaeq peamaeq commented May 18, 2022

No description provided.

@9prady9
Copy link
Member

9prady9 commented May 18, 2022

@peamaeq Please fix the commit message.

@9prady9
Copy link
Member

9prady9 commented May 19, 2022

please also address the formatting and clippy issues

@peamaeq
Copy link
Contributor Author

peamaeq commented May 19, 2022

please also address the formatting and clippy issues

Sorry for the long reply, thanks

@9prady9
Copy link
Member

9prady9 commented May 19, 2022

please also address the formatting and clippy issues

Sorry for the long reply, thanks

I am not sure which long reply you are talking about. I was referring to the commit message "0517". What does that mean ? Can you put some readable text in the commit message.

@peamaeq
Copy link
Contributor Author

peamaeq commented May 20, 2022 •
edited
Loading

please also address the formatting and clippy issues

Sorry for the long reply, thanks

I am not sure which long reply you are talking about. I was referring to the commit message "0517". What does that mean ? Can you put some readable text in the commit message.

I'm so sorry🤦‍♂️, '0517' is date. I'm really no expert with unsafe but my understanding is that you should choose the scopes as small as possible and such that any code outside of the unsafe block can't use it's results to cause havoc. Then people only have to look at these small unsafe blocks and as long as they consider them "safe" the whole code should be safe.

@9prady9 9prady9 self-assigned this Jun 25, 2022
@9prady9 9prady9 added this to the 3.8.2 milestone Jun 25, 2022
9prady9
9prady9 approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@9prady9 9prady9 merged commit edb64d6 into arrayfire:master Sep 11, 2022
@9prady9 9prady9 modified the milestones: 3.8.2, 3.9.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9prady9 9prady9 9prady9 approved these changes

Assignees

@9prady9 9prady9

Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@peamaeq @9prady9