ci: arm64 binaries #1518
ci: arm64 binaries #1518
Conversation
.github/workflows/release.yml
Outdated
| @@ -4,7 +4,7 @@ name: Build binaries for GitHub release | |||
|
|
|||
| on: | |||
| release: | |||
| types: [created, edited, published] | |||
| types: [edited, published] | |||
There was a problem hiding this comment.
question: Why did you remove created here? Don't we still want to build release binaries in that case (particularly to know before publishing the release if there's any issues)?
There was a problem hiding this comment.
the action is triggered twice for each release (see run 1 and 2 here https://github.com/raylu/git-branchless/actions/workflows/release.yml)
There was a problem hiding this comment.
Indeed, it seems like created and published may be redundant in some situations:
- https://stackoverflow.com/questions/59319281/github-action-different-between-release-created-and-published
- https://docs.github.com/en/webhooks/webhook-events-and-payloads#release
-
created: A draft was saved, or a release or pre-release was published without previously being saved as a draft.
-
published: A release, pre-release, or draft of a release was published.
So, if I understand correctly, it looks like created and published may both run if a release is published w/o being first saved as a draft. That said, if the exist config is working for us, it makes sense to me to leave it as it until we can look into it more.
sorry, I'm blind and didn't notice this until just now. done! |
https://github.com/raylu/git-branchless/actions/runs/13598267205 built https://github.com/raylu/git-branchless/releases/tag/v0.10.0
closes #1517