FromStream impls for collections (and more!) #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunjay
force-pushed
the
fromstream-impls
branch
from
02127f2 to
a0193fa
Compare
sunjay
changed the title
|
@yoshuawuyts This PR is ready for review/merge! You should merge #266 first. Once that and this PR are merged, you can check off all the impls for I believe we actually cover even more than what's listed in the original tracking issue. I intentionally went off of the |
|
@sunjay thanks so much for this! -- could you perhaps rebase on master to get the clippy fixes in for CI? Thanks! |
sunjay
force-pushed
the
fromstream-impls
branch
from
246474c to
f968c9a
Compare
|
It's rebased! |
|
All tests are passing; this is really good!! Let's merge this! bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 5, 2019
271: FromStream impls for collections (and more!) r=yoshuawuyts a=sunjay Just opening this to have some visibility on my work as I finish it off. Hopefully will be done in the next day or two, but if not, this is here for someone else to finish it off. I'm currently in the process of adding the `FromStream` impls for all the collections. This is generally a very easy and repetitive process: 1. Look up the impl of `FromIterator` for the given collection, it probably uses the `Extend` trait which is also implemented for that collection 2. Copy and paste the directory for the collection that is closest to the collection you're currently doing (closest in terms of the type parameters needed) 3. Update the `Extend` impl to be for the collection you're implementing, being careful to use the `reserve` method if the collection has one to avoid allocating too many times 4. Update the `FromStream` impl to be for the collection you're implementing 5. Make sure you update the docs in the copied `mod.rs` and that you've updated `collections/mod.rs` 6. Test with `--features unstable` or your code will not be compiled The majority of this work is just looking at what `std` does and adapting it to streams. Honestly it's kind of relaxing after a long day... (maybe I'm weird!) 😄 Co-authored-by: Sunjay Varma <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just opening this to have some visibility on my work as I finish it off. Hopefully will be done in the next day or two, but if not, this is here for someone else to finish it off.
I'm currently in the process of adding the
FromStreamimpls for all the collections. This is generally a very easy and repetitive process:FromIteratorfor the given collection, it probably uses theExtendtrait which is also implemented for that collectionExtendimpl to be for the collection you're implementing, being careful to use thereservemethod if the collection has one to avoid allocating too many timesFromStreamimpl to be for the collection you're implementingmod.rsand that you've updatedcollections/mod.rs--features unstableor your code will not be compiledThe majority of this work is just looking at what
stddoes and adapting it to streams. Honestly it's kind of relaxing after a long day... (maybe I'm weird!) 😄