-
Notifications
You must be signed in to change notification settings - Fork 341
Adds stream::repeat_with #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nits; overall this PR is quite good!
I guess the most unfortunate thing is that async closures aren't available yet, which is somewhat limiting -- but hopefully that'll change soonish!
Co-Authored-By: Yoshua Wuyts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I want to wait for a bit to let @stjepang have a chance to review it (he expressed opinions about stream::from_fn
a while back; we're talking tomorrow) -- but I think this PR should be good to merge otherwise!
Ref: #129
Stdlib: https://doc.rust-lang.org/std/iter/fn.repeat_with.html