Skip to content

Adds stream::repeat_with #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2019
Merged

Adds stream::repeat_with #279

merged 4 commits into from
Oct 16, 2019

Conversation

montekki
Copy link
Member

@montekki montekki commented Oct 5, 2019

Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits; overall this PR is quite good!

I guess the most unfortunate thing is that async closures aren't available yet, which is somewhat limiting -- but hopefully that'll change soonish!

Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

I want to wait for a bit to let @stjepang have a chance to review it (he expressed opinions about stream::from_fn a while back; we're talking tomorrow) -- but I think this PR should be good to merge otherwise!

@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Oct 8, 2019
@yoshuawuyts yoshuawuyts added this to the 0.99.10 milestone Oct 13, 2019
@yoshuawuyts yoshuawuyts merged commit 6eb3ea2 into async-rs:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants