-
Notifications
You must be signed in to change notification settings - Fork 341
[Draft PR] Adds Stream::gt #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nits about the example formatting; but overall very excited for the direction this is going in!
src/stream/stream/mod.rs
Outdated
assert_eq!(single_gt.clone().gt(single.clone()).await, true); | ||
assert_eq!(multi.clone().gt(single_gt.clone()).await, false); | ||
assert_eq!(multi_gt.clone().gt(multi.clone()).await, true); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Determines if the elements of this `Stream` are lexicographically | ||
greater than those of another. | ||
|
||
# Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Examples | |
# Examples | |
Just a friendly ping: this PR needs to be rebased onto master. |
87b1d88
to
be14af5
Compare
Blocked by #268
For issue #129
Based on : https://github.com/rust-lang/rust/blob/master/src/libcore/iter/traits/iterator.rs#L2828