Skip to content

[Draft PR] Adds Stream::gt #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5 commits merged into from
Oct 15, 2019
Merged

[Draft PR] Adds Stream::gt #304

5 commits merged into from
Oct 15, 2019

Conversation

assemblaj
Copy link
Contributor

Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits about the example formatting; but overall very excited for the direction this is going in!

assert_eq!(single_gt.clone().gt(single.clone()).await, true);
assert_eq!(multi.clone().gt(single_gt.clone()).await, false);
assert_eq!(multi_gt.clone().gt(multi.clone()).await, true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Determines if the elements of this `Stream` are lexicographically
greater than those of another.

# Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Examples
# Examples

@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Oct 13, 2019
@ghost
Copy link

ghost commented Oct 15, 2019

Just a friendly ping: this PR needs to be rebased onto master.

@assemblaj
Copy link
Contributor Author

@stjepang @yoshuawuyts Rebased #304, #285 and #273. Creating new branches for #305 and #306 due to rebasing issues.

@ghost ghost merged commit 5f7238e into async-rs:master Oct 15, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants