Add future::delay #349
Add future::delay #349
Conversation
k-nasa
force-pushed
the
add_future_delay
branch
from
ea635fe to
358d2bc
Compare
src/future/future.rs
Outdated
| /// ``` | ||
| #[cfg_attr(feature = "docs", doc(cfg(unstable)))] | ||
| #[cfg(any(feature = "unstable", feature = "docs"))] | ||
| fn delay(self, dur: Duration) -> DelayFuture<Self> |
There was a problem hiding this comment.
We should obfuscate the type here, as we're awaiting async fn in traits to be released. Look at the ret! macro in the stream module
There was a problem hiding this comment.
Like this? 53fa132
I don't know why I'm doing this, can you give me an explanation?
There was a problem hiding this comment.
If a concrete type is returned from a trait, people might start relying on it, making this a compatibility hazard towards a future impl Future... version (which is effectively coming with proper async traits).
|
I fixed it and rebase master branch. |
src/future/future.rs
Outdated
| @@ -99,6 +107,28 @@ extension_trait! { | |||
| } | |||
|
|
|||
| pub trait FutureExt: std::future::Future { | |||
| /// Creates a future that is delayed before it starts yielding items. | |||
There was a problem hiding this comment.
Looking at the implementation, I'm not sure if this documentation is correct.
To my reading, it delays execution of the future for the time time given. It will never be polled before the delay resolves. (which might or might not be what you want)
There was a problem hiding this comment.
fixed. I'm not fluent in English, so it might still be wrong ...
|
Thanks! |
close: #341