Added Extend + FromStream for PathBuf #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned in #183 (comment) that it might be a good idea to add
FromStreamforPathBufsince thestdversion implementsFromIterator. I had a few minutes today, and I still had one more PR left for hacktoberfest, so I thought it'd be fun to add this impl. 😄The
FromStream(andExtend) impls I added are gated under theunstablefeature since they use unstable parts ofasync-std. This PR basically follows suit from my other PRs (#265, #266, etc.). The impls forPathBufwere pretty much identical to the existing ones forVec<T>and other collections.I ran all the tests, rustfmt, and clippy, so hopefully this should be good to go! 🎉
cc @yoshuawuyts