Skip to content

Add "std" feature flag #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7 commits merged into from
Nov 7, 2019
Merged

Add "std" feature flag #476

7 commits merged into from
Nov 7, 2019

Conversation

yoshuawuyts
Copy link
Contributor

@yoshuawuyts yoshuawuyts commented Nov 7, 2019

This adds a "std" feature flag, allowing to opt-in to only the core traits and types. No runtime. Thanks!

Screenshot

default
Screenshot_2019-11-08 async_std - Rust

std
Screenshot_2019-11-08 async_std - Rust(1)

Signed-off-by: Yoshua Wuyts <[email protected]>
Signed-off-by: Yoshua Wuyts <[email protected]>
Signed-off-by: Yoshua Wuyts <[email protected]>
@yoshuawuyts
Copy link
Contributor Author

only thing I couldn't figure out was how to keep exporting task_local from the prelude; suggestions welcome!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting, that was fast! Leaving some nits here and will now try to figure out what's up with the task_local! macro... gimme a sec.

@ghost
Copy link

ghost commented Nov 7, 2019

I resolved my comments and put Future::delay() behind #[cfg(feature = "default")].

@ghost ghost merged commit 335bd34 into master Nov 7, 2019
@ghost ghost deleted the core branch November 7, 2019 23:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant