refactor io dir to be same with std and export IntoInnerError #526
Conversation
yjhmelody
changed the title
|
std export the |
| @@ -269,13 +269,15 @@ | |||
| //! [`Result`]: https://doc.rust-lang.org/std/result/enum.Result.html | |||
| //! [`.unwrap()`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.unwrap | |||
|
|
|||
| const DEFAULT_BUF_SIZE: usize = 8 * 1024; | |||
There was a problem hiding this comment.
should this const be marked pub(crate)? Is that even possible?
I guess I'm a bit confused how you're accessing this from other crates without it having a visibility specifier haha. Feel like I'm missing something about how consts work :P
There was a problem hiding this comment.
Well, I think sub mod always can access father mod.
There was a problem hiding this comment.
Just like write tests in sub mod even for test some private functions.
I think pub(crate) is for being public to current crate and private to extern crate.
There was a problem hiding this comment.
See std::io, I just imitate its way of writing.
No description provided.