Skip to content

update dependence crates #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2020
Merged

update dependence crates #721

merged 2 commits into from
Mar 20, 2020

Conversation

k-nasa
Copy link
Member

@k-nasa k-nasa commented Mar 8, 2020

No description provided.

taiki-e
taiki-e reviewed Mar 8, 2020
View reviewed changes
Cargo.toml Outdated
pin-utils = { version = "0.1.0-alpha.4", optional = true }
slab = { version = "0.4.2", optional = true }

[dev-dependencies]
femme = "1.3.0"
rand = "0.7.3"
surf = "1.0.3"
surf = "2.0.0-alpha.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it is good to depend on pre-release crates. They sometimes break...

k-nasa
k-nasa commented Mar 9, 2020
View reviewed changes
@k-nasa k-nasa marked this pull request as ready for review March 9, 2020 00:09
@k-nasa k-nasa merged commit 2dbebe5 into async-rs:master Mar 20, 2020
@k-nasa k-nasa deleted the update_dep_crate branch March 20, 2020 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e left review comments

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-nasa @dignifiedquire @taiki-e