Skip to content

(feat) add support to secrets (SSM and Secrets Manager) #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

hectorgrecco
Copy link
Contributor

@hectorgrecco hectorgrecco commented Dec 10, 2021

Issue #, if available:
We currently have support for fixed environment variables, but not for sensitive data store at SSM or Secrets Manager.

Description of changes:
I've added a parameter named secrets where you can set SECRET_NAME=AWS_ARN value. I've added a Regex to validate the ARN. I did not write tests, so... If someone could write those tests, the community would be happy :)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@amazreech
Copy link
Contributor

amazreech commented May 10, 2024

Hi @hectorgrecco, thank you so much for your contribution. Apologies on the delay.
We will be working on reviewing Pull Requests on the repository. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please be sure to run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR if any.

@amazreech
Copy link
Contributor

Hi @hectorgrecco, closing this PR out. Similar changes have been submitted as part of PR 152. PR 152 also attributes this PR in their description and is currently under review.

I will add you as a co-contributor you when we merge the other PR. Please let me know if you have any concerns. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants