-
Notifications
You must be signed in to change notification settings - Fork 515
feat: idempotent fetch #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: idempotent fetch #1289
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6dd528e
Add functionality to re-use existing credentials
lehmanmj 32b0eed
Finish adding use-existing-credentials logic
lehmanmj 4c88881
Add testing for use-existing-credentials
lehmanmj 7b1a6ca
Update README
lehmanmj e9f0490
feat: finalize use-exisiting-credentials feature
kellertk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -299,5 +299,23 @@ describe('Configure AWS Credentials', {}, () => { | |
await run(); | ||
expect(core.setFailed).toHaveBeenCalled(); | ||
}); | ||
it('re-uses existing credentials if they are valid', {}, async () => { | ||
vi.clearAllMocks(); | ||
mockedSTSClient.reset(); | ||
vi.spyOn(core, 'getInput').mockImplementation(mocks.getInput(mocks.USE_EXISTING_CREDENTIALS_INPUTS)); | ||
vi.spyOn(core, 'getIDToken').mockResolvedValue('testoidctoken'); | ||
process.env.ACTIONS_ID_TOKEN_REQUEST_TOKEN = 'fake-token'; | ||
|
||
mockedSTSClient.on(AssumeRoleWithWebIdentityCommand).resolvesOnce(mocks.outputs.STS_CREDENTIALS); | ||
kellertk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
mockedSTSClient.on(GetCallerIdentityCommand).resolvesOnce({ ...mocks.outputs.GET_CALLER_IDENTITY_NO_CREDS }); | ||
await run(); | ||
expect(core.info).toHaveBeenCalledWith('No valid credentials exist. Running as normal.') | ||
|
||
mockedSTSClient.on(GetCallerIdentityCommand).resolves({ ...mocks.outputs.GET_CALLER_IDENTITY }); | ||
|
||
mockedSTSClient.on(AssumeRoleWithWebIdentityCommand).resolvesOnce(mocks.outputs.STS_CREDENTIALS); | ||
await run(); | ||
kellertk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
expect(core.info).toHaveBeenLastCalledWith('Pre-existing credentials are valid. No need to generate new ones.') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We shouldn't expect on log messages if we can help it. |
||
}) | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.