-
Notifications
You must be signed in to change notification settings - Fork 326
feat(theming) add custom component style rendering #5812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 33d9824 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
calebpollman
previously approved these changes
Sep 19, 2024
Co-authored-by: Caleb Pollman <[email protected]>
calebpollman
approved these changes
Sep 19, 2024
esauerbo
approved these changes
Sep 19, 2024
Merged
calebpollman
added a commit
that referenced
this pull request
May 15, 2025
Co-authored-by: Caleb Pollman <[email protected]>
calebpollman
added a commit
that referenced
this pull request
May 15, 2025
Co-authored-by: Caleb Pollman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a new feature of the experimental theme v2 work.
We have come across a use-case where a customer wants to create a custom component theme in a separate package, but cannot add that theme to the
createTheme
function due to a circular dependency. This functionality allows customers to just write the CSS that only their component needs, whenever they need to.Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.