Skip to content

feat(theming) add custom component style rendering #5812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

dbanksdesign
Copy link
Contributor

Description of changes

This is a new feature of the experimental theme v2 work.

We have come across a use-case where a customer wants to create a custom component theme in a separate package, but cannot add that theme to the createTheme function due to a circular dependency. This functionality allows customers to just write the CSS that only their component needs, whenever they need to.

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dbanksdesign dbanksdesign requested a review from a team as a code owner September 18, 2024 19:56
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 33d9824

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@aws-amplify/ui-react Minor
@aws-amplify/ui Minor
@aws-amplify/ui-react-auth Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-react-core-auth Patch
@aws-amplify/ui-react-core-notifications Patch
@aws-amplify/ui-react-core Patch
@aws-amplify/ui-react-native-auth Patch
@aws-amplify/ui-react-native Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch
@aws-amplify/ui-react-geo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

calebpollman
calebpollman previously approved these changes Sep 19, 2024
@dbanksdesign dbanksdesign merged commit 0ddeea9 into main Sep 19, 2024
34 checks passed
@dbanksdesign dbanksdesign deleted the themev2-component-styles branch September 19, 2024 16:22
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
calebpollman added a commit that referenced this pull request May 15, 2025
calebpollman added a commit that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants