Skip to content

feat(layers): add parameterised layer deployment and verification #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Jun 10, 2025

Summary

Changes

Please provide a summary of what's being changed

Copies existing GovCloud workflows and parameterises them to accept China also

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3920


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jun 10, 2025
@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Jun 10, 2025
@dreamorosi dreamorosi changed the title feat(china): Create parameterised layer deployment and verification feat(layers): Create parameterised layer deployment and verification Jun 10, 2025
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@dreamorosi dreamorosi changed the title feat(layers): Create parameterised layer deployment and verification feat(layers): add parameterised layer deployment and verification Jun 10, 2025
@dreamorosi dreamorosi linked an issue Jun 10, 2025 that may be closed by this pull request
2 tasks
@dreamorosi
Copy link
Contributor

@sthulb Sonar's analysis seems to have failed. I tried to find a way to trigger it again on their dashboard as per the comment but wasn't able to.

Could you please make another commit, even empty, just to re-trigger the CI?

If we merge it without it'll lower the OSSF score. Thanks.

Copy link

@dreamorosi dreamorosi merged commit 2214ba7 into main Jun 11, 2025
44 checks passed
@dreamorosi dreamorosi deleted the china-layers branch June 11, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PRs that introduce new features or minor changes size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: publish Lambda layers in China regions
2 participants